Typesetting adjustments#213
Merged
conrad-watt merged 5 commits intoWebAssembly:upstream-rebuildfrom Sep 28, 2023
Merged
Conversation
- core/exec/instructions.rst:
+ (notify) Error in html: 'You can't use 'macro parameter character #' in math mode
+ (wait) too long right side of formal rules
- core/exec/relaxed.rst (preliminary defs, nit picks):
+ add brackets due to ambiguous '=' signs in predicate definitions of overlapact, sameact, syncact
+ add linebreaks in some too long lines in rangeact, tearfreeact, \X{func}, syncact,
+ add brackets around 'otherwise' and '\iff ...', to match rest of spec
+ add several '~' to add missing space, after all '\iff'
+ add potentially forgotten '&&' before plain '\\'s
- core/exec/relaxed.rst (consistency, nit picks):
+ add several '~' to add missing space, after predicates consistentwith, suspensionsconsistentwith, readsfrom, valueconsistentwith, hbconsistentwith, sclastvisible, notear,
+ removed potentially misplaced '\,'
+ removed and added some arrays to make the lines less long
In relaxed.rst (traces): was creating the error 'Bracket argument to \\ must be a dimension' It looks less good in the pdf than in the html though.
Tested in html and pdf.
The store is involved in these reductions as well, as it appears in the reduction steps of all other memory instructions which refer to a meminst (all memory instruction reductions except for wait' and fence).
conrad-watt
approved these changes
Sep 28, 2023
conrad-watt
added a commit
that referenced
this pull request
Sep 28, 2023
generated from commit 631684c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages for details on the changes